Skip to content

Change order that booking page prefills information#3003

Merged
zomars merged 1 commit intomainfrom
fix/prefill-booking-page
Jun 7, 2022
Merged

Change order that booking page prefills information#3003
zomars merged 1 commit intomainfrom
fix/prefill-booking-page

Conversation

@joeauyeung
Copy link
Contributor

What does this PR do?

Based on the priority of issue #2823 I changed the order that the booking page prefills information. The new order is the following

  • URL params
  • Session user if not the owner of the event type
  • Blank

Fixes #2823

https://www.loom.com/share/c1d21e3279084a6b923de6f5b6bec0d3

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Log in as the pro user

  • Preview an event type and on the booking page it should be blank

  • Add a URL param (email or name) and the booking page should now have that information

  • Log in as a free user and visit the pro user's booking page

  • The free user's information should be prefilled

  • Add a URL param (email or name) and the booking page should be filled with that information

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jun 7, 2022 at 2:36PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) Jun 7, 2022 at 2:36PM (UTC)
swagger ⬜️ Ignored (Inspect) Jun 7, 2022 at 2:36PM (UTC)
ui ⬜️ Ignored (Inspect) Jun 7, 2022 at 2:36PM (UTC)

@zomars zomars merged commit 55d6f1e into main Jun 7, 2022
@zomars zomars deleted the fix/prefill-booking-page branch June 7, 2022 15:46
@zomars zomars mentioned this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: pre-fill email and name not working

2 participants